Update pterm so it doesn't intercept signals #528
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes
In older versions, the pterm library we use for pretty-printing intercepted SIGINT and SIGTERM. This signal handling was set up in the pacakge's
init
function, so any code that ran before we set up our own signal handler couldn't be killed with Ctrl-C.The signal handling was removed from pterm in a more recent version (see [1]). Updating to the latest fixes the issue where we couldn't kill
up login
with Ctrl-C (#526).[1] pterm/pterm#562
Fixes #526
Signed-off-by: Adam Wolfe Gordon adam.wolfegordon@upbound.io
I have:
make reviewable
to ensure this PR is ready for review.backport release-x.y
labels to auto-backport this PR, as appropriate.How has this code been tested
up login
can be killed with Ctrl-C at either theUsername
or thePassword
prompt, with or without entering input first.make test
to ensure the dependency update didn't break any unit tests.up ctx
,up ctp list
,up space list
) to validate that output still looks right.