Support for installing/upgrading charts from local files & dirs #107
Conversation
Signed-off-by: Alper Rifat Ulucinar <ulucinar@users.noreply.github.com>
There was a problem hiding this comment.
@ulucinar thanks for working on this! We had previously been somewhat hesitant to add this type of functionality because of the potential to support other installer backends than Helm. However, I think this is a very useful feature and don't want to hold off on its implementation due to the potential of supporting something else in the future :) I left one comment below, but I was also wondering if you felt making --chart more generic, maybe something like --bundle or --src would be an improvement or just more confusing? If we kept it as --chart that is obviously specific to Helm, but the alternatives are more generic and could be supported for other installers. On the other hand, we could just say --chart is only valid if using the Helm installer. What do you think?
- Rename "--chart" as "--bundle" - Remove Helm from description strings Signed-off-by: Alper Rifat Ulucinar <ulucinar@users.noreply.github.com>
|
Hi @hasheddan, If, in the future, a new bundle format that we adopt does not somehow support installation/upgrades from a local path, then we may have to remove this flag but I think this is fair. |
Description of your changes
This PR adds support for installing/upgrading crossplane (or uxp) charts from a local chart archive or a local directory. The local chart to be processed can be specified with the
--bundlecommand-line option.Note: I'm planning to use the changes in this PR in the demo, and I believe it could prove to be useful for development scenarios. If this functionality is already provided by other means, or if you believe it's not appropriate, we can close this PR.
I have:
make reviewableto ensure this PR is ready for review.backport release-x.ylabels to auto-backport this PR, as appropriate.How has this code been tested
Manually tested installing a downloaded UXP chart both from an archive and from a folder containing extracted contents. Also verified installations & upgrades from a Helm repo still work.