Move all cloud commands to top-level root
#117
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updates the internal config structure and methods to use upbound instead of cloud to refer to configuration that is related to interacting with Upbound. This is a breaking change despite being an internal package, but it will only require users logging in again, at which point their existing config file will be overwritten with the revised structure. Signed-off-by: hasheddan <georgedanielmangum@gmail.com>
Renames the internal cloud package to upbound to reflect that the context it provides is for interacting with the upbound API. Signed-off-by: hasheddan <georgedanielmangum@gmail.com>
Moves the ExtractConfig helper function to the config package where it can live alongside the data structures it interacts with. Signed-off-by: hasheddan <georgedanielmangum@gmail.com>
Updates all Upbound Cloud commands to consume the refactored structure of the config and upbound packages. No functional changes. Signed-off-by: hasheddan <georgedanielmangum@gmail.com>
Moves all cloud commands to root level as they should be used for interacting with Upbound, not just Upbound Cloud. Signed-off-by: hasheddan <georgedanielmangum@gmail.com>
BeforeApply hooks must return an error, so we ignore linter error that we always return nil. Signed-off-by: hasheddan <georgedanielmangum@gmail.com>
hasheddan
requested review from
grantgumina,
AaronME,
nullable-eth and
tnthornton
tnthornton
approved these changes
Sep 13, 2021
Updates all commands to accept kong.Context with name kongCtx for consistency. Also removed the parameter from some commands and hooks that do not require it. Signed-off-by: hasheddan <georgedanielmangum@gmail.com>
tnthornton
approved these changes
Sep 13, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes
Moves all
cloudcommands to the top-level root, resulting in:up loginup logoutup controlplane ...This is a fairly large breaking change, but should be straightforward for users to adapt to. The most noticeable change is that the on-disk config file structure is slightly modified. But a user running
up loginwill automatically have their config file restructured in the new format. They will be required to login each profile they previously had.Expand for prior command structure
Expand for new command structure
Fixes #114
I have:
make reviewableto ensure this PR is ready for review.backport release-x.ylabels to auto-backport this PR, as appropriate.How has this code been tested
I have tested each set of the commands that have been moved, including:
up loginup login -a danup logoutup ctp create test -a danup ctp kubeconfig get --token=<token> <cp-id> -a dank get pods -Aup ctp token list <cp-id> -a danup ctp delete <cp-id>