Add up enterprise mail command #155
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds a simple mail portal template for rendering emails stored as secrets in a cluster. Signed-off-by: hasheddan <georgedanielmangum@gmail.com>
Adds a command to run a small local webserver that renders emails stored as secrets in a cluster. Signed-off-by: hasheddan <georgedanielmangum@gmail.com>
Adds unit tests for enterprise mail command. Signed-off-by: hasheddan <georgedanielmangum@gmail.com>
We are opting to make the command visible for discoverability, but mark it explicitly as experimental. Signed-off-by: hasheddan <georgedanielmangum@gmail.com>
Adds the 1.17 go generate directive. Signed-off-by: hasheddan <georgedanielmangum@gmail.com>
hasheddan
commented
Feb 14, 2022
| @@ -51,6 +51,7 @@ func (c *Cmd) AfterApply(kongCtx *kong.Context) error { | |||
| // Cmd contains commands for managing enterprise. | |||
| type Cmd struct { | |||
| Install installCmd `cmd:"" group:"enterprise" help:"Install enterprise."` | |||
| Mail mailCmd `cmd:"" group:"enterprise" help:"[EXPERIMENTAL] Run a local mail portal."` | |||
There was a problem hiding this comment.
Opted to make visible as it will likely be recommended route for quickstart, but marked explicitly as EXPERIMENTAL. Probably should think about potentially making a config flag that turns experimental features on or off soon...
tnthornton
approved these changes
Feb 14, 2022
| @@ -12,6 +12,7 @@ | |||
| // See the License for the specific language governing permissions and | |||
| // limitations under the License. | |||
|
|
|||
| //go:build generate | |||
There was a problem hiding this comment.
Guessing this came in through going to go 1.17? I seem to remember something similar happening in my provider-aws PR awhile back.
There was a problem hiding this comment.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes
Adds
up enterprise mailEXPERIMENTAL command for viewing emails that are stored asSecrets in a Kubernetes cluster using a small mail portal provided by a local server.I have:
make reviewableto ensure this PR is ready for review.backport release-x.ylabels to auto-backport this PR, as appropriate.How has this code been tested
Tested this out with a cluster with valid emails as
Secrets.