Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Go 1.18 #213

Merged
merged 4 commits into from
Aug 3, 2022
Merged

Use Go 1.18 #213

merged 4 commits into from
Aug 3, 2022

Conversation

epk
Copy link
Contributor

@epk epk commented Aug 2, 2022

Signed-off-by: Aditya Sharma git@adi.run

Description of your changes

Opened in place of #209

  • Use Go 1.18
  • Fix misc lint errors

I have:

  • Read and followed Upbound's contribution process.
  • Run make reviewable to ensure this PR is ready for review.
  • Added backport release-x.y labels to auto-backport this PR, as appropriate.

How has this code been tested

make reviewable + full CI run

@epk epk self-assigned this Aug 2, 2022
@epk epk force-pushed the epk/go1-18-1 branch 5 times, most recently from be26f65 to 044b578 Compare August 2, 2022 19:57
Signed-off-by: Aditya Sharma <git@adi.run>
@epk epk changed the title Use Go 1.18 Take 2 Use Go 1.18 Aug 2, 2022
@epk epk marked this pull request as ready for review August 2, 2022 20:04
epk added 2 commits August 2, 2022 13:05
Signed-off-by: Aditya Sharma <git@adi.run>
Signed-off-by: Aditya Sharma <git@adi.run>
Makefile Outdated Show resolved Hide resolved
Signed-off-by: Aditya Sharma <git@adi.run>
Copy link
Contributor

@hasheddan hasheddan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @epk!

@epk epk merged commit e40b973 into main Aug 3, 2022
@epk epk deleted the epk/go1-18-1 branch August 3, 2022 18:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants