Only pass domain to docker-credential-up #217
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
up requires that commands provide a scheme in the UP_DOMAIN, but doing so causes a failure to match to registry domain in docker-credential-up, meaning that a separate UP_DOMAIN value must be used for up and docker-credential-up. This corrects that behavior to parse the hostname from UP_DOMAIN in docker-credential-up and only pass it along as the domain for matching. Signed-off-by: hasheddan <georgedanielmangum@gmail.com>
tnthornton
approved these changes
Aug 5, 2022
|
/backport |
|
Successfully created backport PR #220 for |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes
up requires that commands provide a scheme in the UP_DOMAIN, but doing
so causes a failure to match to registry domain in docker-credential-up,
meaning that a separate UP_DOMAIN value must be used for up and
docker-credential-up. This corrects that behavior to parse the hostname
from UP_DOMAIN in docker-credential-up and only pass it along as the
domain for matching.
Signed-off-by: hasheddan georgedanielmangum@gmail.com
Fixes #191
I have:
make reviewableto ensure this PR is ready for review.backport release-x.ylabels to auto-backport this PR, as appropriate.How has this code been tested
Verified by setting
UP_DOMAIN-https://upbound.ioand pushing successfully usingdocker pushwithdocker-credential-upconfigured in~/.docker/config.json.