Update MCP experimental ctp list with paging #225
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updates up-sdk-go to lates to pick up paging support. Signed-off-by: hasheddan <georgedanielmangum@gmail.com>
Updates control plane listing with experimental MCP API with support for paging. Currently we just max out page size, but we may opt to support limiting page size and iterating pages in the future via flags. Signed-off-by: hasheddan <georgedanielmangum@gmail.com>
epk
approved these changes
Aug 10, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes
Updates control plane listing with experimental MCP API with support for
paging. Currently we just max out page size, but we may opt to support
limiting page size and iterating pages in the future via flags.
Signed-off-by: hasheddan georgedanielmangum@gmail.com
I have:
make reviewableto ensure this PR is ready for review.backport release-x.ylabels to auto-backport this PR, as appropriate.How has this code been tested
Verified that I can successfully list control planes with experimental API: