Ignore whitespace when parsing examples #278
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updates examples parser to ignore whitespace. If a YAML document is provided that contains only whitespace then it is skipped, but does not cause an error. This is in alignment with the API types parser. Signed-off-by: hasheddan <georgedanielmangum@gmail.com>
Updates the examples parser to annotate the error if the ReadCloser supports doing so. Signed-off-by: hasheddan <georgedanielmangum@gmail.com>
hasheddan
commented
Nov 10, 2022
tnthornton
reviewed
Nov 10, 2022
Comment on lines
+69
to
+71
| if isWhiteSpace(bytes) { | ||
| continue | ||
| } |
There was a problem hiding this comment.
Thoughts on adding a test case or two for the behavior you're seeing? I clearly failed to add tests in this package the first time through 😞 , but in the event we find a fix, it would be good to know if/when we accidentally regressed the changes 👍.
There was a problem hiding this comment.
Yep, will add tests before moving out of draft -- I discovered this is an issue upstream as well though so will likely fix then propagate 👍🏻
|
@hasheddan Is this PR still relevant? |
|
@muvaf it is still relevant but is is not ready to be merged. I'll see if I can push this forward or convert to an issue 👍🏻 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes
Updates examples parser to ignore whitespace. If a YAML document is provided that contains only whitespace then it is skipped, but does not cause an error. This is in alignment with the API types parser.
Signed-off-by: hasheddan georgedanielmangum@gmail.com
I have:
make reviewableto ensure this PR is ready for review.backport release-x.ylabels to auto-backport this PR, as appropriate.How has this code been tested
Testing in progress.. will be updated shortly.