Add AWS support to up spaces billing get
#347
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
nlinx
force-pushed
the
spacesAWS
branch
3 times, most recently
from
6ded32b
to
a9b5468
Compare
AlainRoy
reviewed
Aug 7, 2023
branden
reviewed
Aug 7, 2023
cmd/up/space/billing/get.go
Outdated
| @@ -168,7 +174,7 @@ func (c *getCmd) cleanupOnError() { | |||
| } | |||
| } | |||
|
|
|||
| func (c *getCmd) collectReport() error { | |||
| func (c *getCmd) collectReport() error { //nolint:gocyclo | |||
There was a problem hiding this comment.
Could this method be refactored so that it isn't hitting the cyclomatic complexity limit? The switch or its cases look like a juicy target for factoring out into a separate method.
There was a problem hiding this comment.
Bump, let's refactor this method instead of silencing the gocyclo linter on it.
nlinx
force-pushed
the
spacesAWS
branch
3 times, most recently
from
ef3cf6e
to
fdc3b15
Compare
branden
reviewed
Aug 8, 2023
cmd/up/space/billing/get.go
Outdated
| @@ -168,7 +174,7 @@ func (c *getCmd) cleanupOnError() { | |||
| } | |||
| } | |||
|
|
|||
| func (c *getCmd) collectReport() error { | |||
| func (c *getCmd) collectReport() error { //nolint:gocyclo | |||
There was a problem hiding this comment.
Bump, let's refactor this method instead of silencing the gocyclo linter on it.
branden
approved these changes
Aug 8, 2023
internal/usage/report/gcs/gcs.go
Outdated
| @@ -39,10 +41,27 @@ const ( | |||
| errWriteEvents = "error writing events" | |||
| ) | |||
|
|
|||
| // MaxResourceCountPerGVKPerMCP reads usage data for an account and time range | |||
| // GenerateReport | |||
There was a problem hiding this comment.
lol that's what i get for stepping away to eat while writing doc string
| @@ -40,10 +41,29 @@ const ( | |||
| errWriteEvents = "error writing events" | |||
| ) | |||
|
|
|||
| // MaxResourceCountPerGVKPerMCP reads usage data for an account and time range | |||
| func GenerateReport(ctx context.Context, account, endpoint, bucket string, billingPeriod usage.TimeRange, w report.MCPGVKEventWriter) error { | |||
internal/usage/report/gcs/gcs.go
Outdated
Comment on lines
22
to
23
| "cloud.google.com/go/storage" | ||
|
|
There was a problem hiding this comment.
nit: cloud.google.com/go/storage should be grouped with the other third-party imports below.
branden
approved these changes
Aug 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes
up spaces billing getFixes #
https://github.com/upbound/mxe/issues/143
I have:
make reviewableto ensure this PR is ready for review.backport release-x.ylabels to auto-backport this PR, as appropriate.How has this code been tested