Spaces: add helpers for default and unattended installation #357
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
tnthornton
reviewed
Aug 14, 2023
cmd/up/space/defaults/defaults.go
Outdated
Comment on lines
50
to
51
| "global.clusterType": string(cloud), | ||
| "ingress.provision": "true", |
There was a problem hiding this comment.
For the current release of spaces, these are no longer valid properties 👍
There was a problem hiding this comment.
Ah, I'll get that fixed up
cmd/up/space/defaults/defaults.go
Outdated
Comment on lines
27
to
30
| CloudAzureAKS CloudType = "aks" | ||
| CloudAmazonEKS CloudType = "eks" | ||
| CloudGoogleGKE CloudType = "gke" | ||
| CloudGeneric CloudType = "generic" |
There was a problem hiding this comment.
nit - since we have CloudType, could we trim the Cloud prefix from each of these names?
Added `--yes` for unattended installation of Spaces and setting defaults for managed Kubernetes. Signed-off-by: Ben Howard <ben@upbound.io>
darkmuggle
force-pushed
the
pr/spaces-helpers
branch
from
ec06cab
to
70ea901
Compare
tnthornton
approved these changes
Aug 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes
Added
--yesfor unattended installation of Spaces and setting defaults for managed Kubernetes.I have:
make reviewableto ensure this PR is ready for review.backport release-x.ylabels to auto-backport this PR, as appropriate.How has this code been tested
Tested against GKE and EKS.