Allow pre-release versions of spaces to be installed and upgraded to #387
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Taylor Thornton <thornton.tn@gmail.com>
darkmuggle
approved these changes
Oct 6, 2023
AlainRoy
approved these changes
Oct 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes
Prior to this change, we were unfortunately blocking pre-release installations. Maybe in the future, we choose to take a different stance, however today, not being able to install pre-release versions is pretty limiting when working on those earlier versions in conjunction with
upas well as if we need to get a pre-release fix out to an external consumer.I have:
make reviewableto ensure this PR is ready for review.How has this code been tested
Added new tests that cover the use case I ran into. I verified that the tests failed prior to adjusting the constraints in this changeset.