-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move ctp connect
to ctp connector install
#389
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is way better than I would have done, had I finished it. It looks great, and I like the approach to having a unified response for the two kinds of control planes.
My only comments are nits -- very small.
One question: The description for the PR sounds much more limited than what is actually here. Is the description wrong, or did you not intend to include everything in this PR? I'm okay with it all being included, just making sure it's what you expect.
Other than that last concerns (about the description matching the contents), I'm happy and will pre-emptively approve, assuming you'll fix the description if appropriate.
Wait, I looked that the PRs in the wrong order: this overlaps #388. I'm guessing this PR needs to be updated? Maybe you should ignore my approval there. |
Ya, this is branched from #388 and builds on that guy. I called that out in the description too 👍 . I'm guessing this is the reason for this comment:
? |
Yeah, I just got confused since it's awaiting the merge, so there was more code. It all looks good though. |
Signed-off-by: Taylor Thornton <thornton.tn@gmail.com>
0072d5a
to
7e36bdc
Compare
Signed-off-by: Taylor Thornton <thornton.tn@gmail.com>
Description of your changes
This PR shuffles the subcommands around a little. This is in anticipation of some reworking for
ctp connect
.This changeset builds on #388. #388 should be merged/reviewed prior to this PR.
I have:
make reviewable
to ensure this PR is ready for review.How has this code been tested