ctx: fix group+controlplane context code and add tests #462
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Dr. Stefan Schimanski <stefan.schimanski@upbound.com>
sttts
force-pushed
the
sttts-ctx-kubeconfig-fixes-and-tests
branch
from
00ddca8
to
cbdc775
Compare
tnthornton
approved these changes
Apr 15, 2024
There was a problem hiding this comment.
Thanks @sttts for all of the tests 🙇
I have a couple of nits, but nothing blocking.
| t.Run(name, func(t *testing.T) { | ||
| g := &Group{name: tt.group} | ||
| conf, last, err := g.accept(tt.conf, profile.Profile{KubeContext: "profile"}, tt.preferred) | ||
| if diff := cmp.Diff(tt.wantErr, fmt.Sprintf("%v", err)); diff != "" { |
There was a problem hiding this comment.
nit - instead of converting to a string, we could do something like
if diff := cmp.Diff(tt.wantErr, err, test.EquateErrors())There was a problem hiding this comment.
It's too strict. I know that Crossplane does it. But it checks the underlying type. IMO it is not what you want in most cases.
| t.Run(name, func(t *testing.T) { | ||
| ctp := &ControlPlane{NamespacedName: tt.ctp} | ||
| conf, last, err := ctp.accept(tt.conf, profile.Profile{KubeContext: "profile"}, "https://ingress", []byte{1, 2, 3}, tt.preferred) | ||
| if diff := cmp.Diff(tt.wantErr, fmt.Sprintf("%v", err)); diff != "" { |
There was a problem hiding this comment.
Similar comment for down here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up of #455, doing what @tnthornton suggested in #455 (comment).