Match kubectl behavior in commands that use kubeconfig #79
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The kubeconfig builder will automatically use KUBECONFIG env var if present, so we do not need to replicated the behavior in commands we support. Signed-off-by: hasheddan <georgedanielmangum@gmail.com>
The kubeconfig getter now loads default chains for loading kubeconfig from environment variables and default path if an explicit path is not set. Signed-off-by: hasheddan <georgedanielmangum@gmail.com>
Revises the kubeconfig flag description to more accurately describe its behavior. Signed-off-by: hasheddan <georgedanielmangum@gmail.com>
AaronME
approved these changes
May 19, 2021
Updated docstring for kubeconfig getter to appropriately represent behavior. Signed-off-by: hasheddan <georgedanielmangum@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates
--kubeconfigflags to not explicitly use environment variables and instead fall back on default kubeconfig loader chain used bykubectl. This means thatupis only overriding behavior if an explicit existing path is passed to--kubeconfig.Fixes #77
Tested this out by creating two different kind clusters and running the following scenarios after exporting kubeconfigs to
first.yamlandsecond.yaml:KUBECONFIGthat includesfirst.yamlbut notsecond.yaml-- first cluster is usedKUBECONFIGthat includessecond.yamlbut notfirst.yaml-- second cluster is usedKUBECONFIGthat includesfirst.yamlbeforesecond.yaml-- first cluster is usedKUBECONFIGand current context in~/.kube/kubeconfigis used--kubeconfigand the specified file is used