Strip leading v off of UXP version when pulling chart #85
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Strips the leading v off of any UXP versions supplied when pulling the chart so that it matches how Helm caches it. An alternative approach would be to parse into structured semantic version prior to passing to Helm, but we prefer to defer that logic to Helm rather than parsing into semver twice. If additional modification were made by Helm in the future, this functionality could break, but we would prefer to hit the issue rather than potentially pulling and installing incorrect UXP versions. Signed-off-by: hasheddan <georgedanielmangum@gmail.com>
AaronME
approved these changes
May 24, 2021
hasheddan
commented
May 24, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Strips the leading v off of any UXP versions supplied when pulling the
chart so that it matches how Helm caches it. An alternative approach
would be to parse into structured semantic version prior to passing to
Helm, but we prefer to defer that logic to Helm rather than parsing into
semver twice. If additional modification were made by Helm in the
future, this functionality could break, but we would prefer to hit the
issue rather than potentially pulling and installing incorrect UXP versions.
Signed-off-by: hasheddan georgedanielmangum@gmail.com
Fixes #84