yaml target should be able to parse key containing dots #1148
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Olblak <me@olblak.com>
Signed-off-by: Olblak <me@olblak.com>
👇 Click on the image for a new way to code review
Legend |
olblak
changed the title
olblak
added
bug
dduportal
reviewed
Feb 12, 2023
Comment on lines
+24
to
+45
| { | ||
| name: "Passing Case with 'File' and complex key", | ||
| spec: Spec{ | ||
| File: "test.yaml", | ||
| Key: "annotations.github\\.owner", | ||
| }, | ||
| files: map[string]string{ | ||
| "test.yaml": "", | ||
| }, | ||
| inputSourceValue: "olblak", | ||
| mockedContents: map[string]string{ | ||
| "test.yaml": `--- | ||
| annotations: | ||
| github.owner: olblak | ||
| repository: charts | ||
| `, | ||
| }, | ||
| wantedContents: map[string]string{ | ||
| "test.yaml": "olblak", | ||
| }, | ||
| isResultWanted: true, | ||
| }, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#650 introduce a regression where a yaml target wouldn't correctly parse yaml key using dots
Test
To test this pull request, you can run the following commands:
Additional Information
Tradeoff
Potential improvement