New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add `spec.files` for Condition and Target of `kind` `yaml` #650

Merged

olblak merged 53 commits into updatecli:main from lemeurherve:is-435-yaml-files

Feb 1, 2023

Member

lemeurherve commented Apr 14, 2022 •

edited

feat(yaml): implement spec.files for kind: yaml

Follow-up of #490
Ref #435

Allow to specify more than one file as target for kind: yaml

Like what have been done for kind: file, the possibility to specify multiple files is only possible in the targets stage.

Test

To test this pull request, you can run the following commands:

cp <to_package_directory>
go test

Additional Information

Tradeoff

Potential improvement


          feat(yaml): implement spec.files for kind: yaml

96c6acd

Follow-up of updatecli#490
Ref updatecli#435

lemeurherve added the enhancement label

lemeurherve marked this pull request as ready for review

April 14, 2022 16:14

lemeurherve requested review from dduportal and olblak

April 14, 2022 16:14

lemeurherve added the resource-yaml label

lemeurherve and others added 3 commits

April 14, 2022 18:22


          Merge branch 'main' into is-435-yaml-files

2af1ace


          Merge branch 'main' into is-435-yaml-files

b776807


          Merge branch 'main' into is-435-yaml-files

d33e111

olblak reviewed

View reviewed changes

examples/updatecli.generic/yaml-files.yaml Outdated Show resolved Hide resolved

olblak reviewed

View reviewed changes

pkg/plugins/resources/yaml/condition.go Outdated Show resolved Hide resolved

olblak reviewed

View reviewed changes

pkg/plugins/resources/yaml/main.go Outdated Show resolved Hide resolved

olblak reviewed

View reviewed changes

pkg/plugins/resources/yaml/main.go Outdated Show resolved Hide resolved

olblak reviewed

View reviewed changes

pkg/plugins/resources/yaml/main.go Outdated Show resolved Hide resolved

olblak reviewed

View reviewed changes

pkg/plugins/resources/yaml/main.go Outdated Show resolved Hide resolved

olblak reviewed

View reviewed changes

pkg/plugins/resources/yaml/source.go Outdated Show resolved Hide resolved

olblak reviewed

View reviewed changes

pkg/plugins/resources/yaml/source.go Outdated Show resolved Hide resolved

olblak and others added 3 commits

May 12, 2022 11:57


          Add e2e test for yaml (#43)

213d85e


          Apply suggestions from code review

1af4881

Co-authored-by: Olivier Vernin <olivier@vernin.me>


          chore: move test to e2e success folder

1c2cbb9

lemeurherve marked this pull request as draft

June 5, 2022 14:33


          wip: first stab at files for condition too

957f21e

lemeurherve mentioned this pull request

feat(yaml): implement spec.files for kind: yaml conditions too #729

Closed

lemeurherve and others added 6 commits

June 21, 2022 11:37


          Merge branch 'main' into is-435-yaml-files

ed66fee


          Revert "wip: first stab at files for condition too"

9f0ec9e

This reverts commit 957f21e.


          restore comment, will be done in updatecli#729


          chore: replace deprecated sourceID field by sourceid

584af0c


          fix: e2e tests

ee8a152


          breaking?: no error if the target content hasn't changed

4de4f95

lemeurherve marked this pull request as ready for review

June 21, 2022 13:09

lemeurherve changed the title ~~feat(yaml): implement spec.files for Target of kind yaml~~ feat(yaml): implement spec.files for Conditions and Target of kind yaml

lemeurherve added the condition label

dduportal mentioned this pull request

chore(e2e tests) add a minimalistic documentation + add a makefile dependency to autogenerate a local binary #1120

Draft


          replace example by e2e test

482cf3c

lemeurherve changed the title ~~feat(yaml): implement spec.files for Conditions and Target of kind yaml~~ feat(yaml): implement spec.files for Condition and Target of kind yaml

lemeurherve requested review from olblak and dduportal

January 29, 2023 17:08


          Merge branch 'main' into is-435-yaml-files

229b6e2

dduportal previously approved these changes

View reviewed changes


          correct check for s.file

cd1b41e

lemeurherve dismissed dduportal’s stale review via

cd1b41e

January 30, 2023 12:34

olblak added 4 commits

January 30, 2023 15:02


          Merge branch 'main' into is-435-yaml-files

fbd857a


          Merge branch 'main' into is-435-yaml-files

971d201


          Merge branch 'main' into is-435-yaml-files

9f6de00


          Merge branch 'main' into is-435-yaml-files

e1801b0

olblak previously approved these changes

View reviewed changes

olblak reviewed

View reviewed changes

pkg/plugins/resources/yaml/main.go Outdated Show resolved Hide resolved


          Update pkg/plugins/resources/yaml/main.go

76f5244

olblak dismissed their stale review via

76f5244

February 1, 2023 14:02

olblak enabled auto-merge (squash)

February 1, 2023 14:02

olblak changed the title ~~feat(yaml): implement spec.files for Condition and Target of kind yaml~~ Add spec.files for Condition and Target of kind yaml

olblak disabled auto-merge

February 1, 2023 14:29

olblak merged commit 58c4303 into updatecli:main

Member

olblak commented Feb 1, 2023

Thanks @hervelemeur for your patience

olblak mentioned this pull request

yaml target should be able to parse key containing dots #1148

Merged

olblak modified the milestones: 0.45.0, 0.44.0

lemeurherve deleted the is-435-yaml-files branch

February 28, 2023 14:17

lemeurherve mentioned this pull request

fix yaml resource source filepath #1187

Merged

olblak mentioned this pull request

Allow to override yaml indentation during yaml target stage #1199

Merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment