Target using SCM should be indempotent

[olblak]

Requirement

• When using git scm with push=false only the last target is left committed  #1133

Description

Fix #1162

At the moment the target execution combined with scm is not idempotent.

Running first updatecli apply --config manifest --push=false will clone the repository, update the files, but not publish the changes, as --push=false is specified.
If we run a second time the same command without --push=false, Updatecli will not change any files as local files are already up to date and won't push the changes as nothing change in the current pipeline execution.

They are a few workaround which must result in deleting the local directory.

I propose in this pullrequest to check for each target execution if the current working branch such as updatecli_xxx has the same commit hash than the source branch such as main and if the remote of updatecli_xxx exist.

The goal is to identify if the current working breach has left over changes that need to be publish

Test

To test this pull request, you can run the following commands:

cp <to_package_directory>
go test

Additional Information

Tradeoff

Potential improvement

• Add a flag to disable scm behavior
• Execute action in DRY_RUN mode if apply parameter --push=false is set #1174
• --debug should list commits that need to be push

[ghost]

👇 Click on the image for a new way to code review

Legend

[olblak]

After additional thought, this #1133 should be fixed by removing the reset operation done during the git checkout