Execute action in DRY_RUN mode if apply parameter --push=false is set #1174
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When we run
updatecli apply --push=false
, at the moment Updatecli still tries to apply action such as opening github pullrequest. Obviously if local changes haven't been published then that operation fails as the branch do not exist on the remote location. This is especially confusing for newcomers as they think that the pipeline failed due to the pullrequest even though the root cause is usually at the git operation level.updatecli apply --config updatecli/updatecli.d/golangci-lint.yaml --push=false --clean=false --debug
I often use --push=false to test the local behavior before changing the remote repository
Before fix Output
After fix Output
Additional Information
Tradeoff
While the initial intend of
--push=false
was to disablegit push
operation, I am evolving the concept to all actions which may have side effect in mid-long term as we add more "action" kind.Potential improvement