fix yaml resource source filepath

[olblak]

While automating a file update, I spot a regression where the yaml resource wouldn't use the correct filepath when used with scm.

Test

I updated the e2e tests to catch this issue but it's worth mentioning they will only pass once the current pullrequest is merged on the main branch

Additional Information

Tradeoff

Potential improvement

• A source pipeline shouldn't set by default the current working directory. It's very confusing in resource plugins.

  updatecli/pkg/core/pipeline/source/main.go

  Line 52 in 427cb77

  pwd, err := os.Getwd()

  I would need to investigate the initial intend and then review all plugins as I first noticed this behavior in the cargo package plugin and now in the yaml

[ghost]

👇 Click on the image for a new way to code review

Legend

[olblak]

Also while running some tests, I noticed that a key not found in a yaml will not return an error
https://github.com/updatecli/updatecli/blob/main/pkg/plugins/resources/yaml/source.go#L63L67

I can't remember if it's on purpose. @dduportal @hervelemeur maybe you recall some decision around that

[lemeurherve]

Also while running some tests, I noticed that a key not found in a yaml will not return an error
main/pkg/plugins/resources/yaml/source.go#L63L67

I can't remember if it's on purpose. @dduportal @hervelemeur maybe you recall some decision around that

No idea, sorry. There was some comments about another key in my PR, but unrelated to that one: #650 (comment)