Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow to override yaml indentation during yaml target stage #1199

Merged
merged 3 commits into from
Mar 2, 2023
Merged

Allow to override yaml indentation during yaml target stage #1199

merged 3 commits into from
Mar 2, 2023

Conversation

olblak
Copy link
Member

@olblak olblak commented Mar 2, 2023 •
edited

Fix #1198

Test

To test this pull request, you can run the following commands:

cd pkg/plugins/resources/yaml/
go test .

Additional Information

Tradeoff

Potential improvement

@olblak
Reuse yaml encoder instead of marshal
17c2148 
Signed-off-by: Olblak <me@olblak.com>
@olblak
Allow to set yaml indent, default back to 2
7cbe77d 
Signed-off-by: Olblak <me@olblak.com>
@olblak olblak added resource-yaml Resource of kind YAML enhancement New feature or request labels Mar 2, 2023
@olblak olblak changed the title Fix yaml indent Allow to override yaml indentation during yaml target stage Mar 2, 2023
@olblak
remove duplicated conversion
8de8714 
Signed-off-by: Olblak <me@olblak.com>
@olblak olblak merged commit 496b8c3 into updatecli:main Mar 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
enhancement New feature or request resource-yaml Resource of kind YAML
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

indentation mixup
1 participant
@olblak