Add Updatecli integration with Udash part 1 #1344
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Olblak <me@olblak.com>
handle error Signed-off-by: Olblak <me@olblak.com>
Signed-off-by: Olblak <me@olblak.com>
Signed-off-by: Olblak <me@olblak.com>
Signed-off-by: Olblak <me@olblak.com>
olblak
changed the title
olblak
changed the title
Signed-off-by: Olblak <me@olblak.com>
Signed-off-by: Olblak <me@olblak.com>
Signed-off-by: Olblak <me@olblak.com>
olblak
changed the title
Signed-off-by: Olblak <me@olblak.com>
Signed-off-by: Olblak <me@olblak.com>
Signed-off-by: Olblak <me@olblak.com>
Signed-off-by: Olblak <me@olblak.com>
Signed-off-by: Olblak <me@olblak.com>
Signed-off-by: Olblak <me@olblak.com>
Signed-off-by: Olblak <me@olblak.com>
The purpose of this commit is to reduce the need to specify front and back url by storing those two informations in the configuration file Then a report api can either be specified using a environment variable or relying on the default config Signed-off-by: Olblak <me@olblak.com>
Signed-off-by: Olblak <me@olblak.com>
Signed-off-by: Olblak <me@olblak.com>
Signed-off-by: Olblak <me@olblak.com>
dduportal
reviewed
Jul 6, 2023
dduportal
reviewed
Jul 6, 2023
dduportal
reviewed
Jul 6, 2023
dduportal
reviewed
Jul 6, 2023
dduportal
reviewed
Jul 6, 2023
dduportal
reviewed
Jul 6, 2023
Co-authored-by: Damien Duportal <damien.duportal@gmail.com>
This reverts commit fc32d7f.
Signed-off-by: Olblak <me@olblak.com>
Signed-off-by: Olblak <me@olblak.com>
Signed-off-by: Olblak <me@olblak.com>
dduportal
previously approved these changes
Jul 10, 2023
Signed-off-by: Olblak <me@olblak.com>
olblak
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As an experiment to publish Updatecli report on an Updatecli backend.
This pullrequest introduces the two following enhancements
This pullrequest is designed to work with:
Test
To test this pull request, you can run the following commands (if udash is available on localhost):
go build -o bin/updatecli . ./bin/updatecli login http://localhost:8081 --experimental ./bin/updatecli diff --config updatecli/updatecli.d/updatecli.yaml --experimentalAdditional Information
Tradeoff
Potential improvement
As my learning goes, another popular authentication mechanism uses "the device flow" which is already used to authenticate on GitHub api...
I have an open question on https://community.auth0.com/t/pkce-flow-risk-of-exposing-publicly-authdomain-and-clientid/108278