-
-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Updatecli integration with Udash Part 2 #1418
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Olblak <me@olblak.com>
Signed-off-by: Olblak <me@olblak.com>
Signed-off-by: Olblak <me@olblak.com>
Signed-off-by: Olblak <me@olblak.com>
Signed-off-by: Olblak <me@olblak.com>
Signed-off-by: Olblak <me@olblak.com>
Signed-off-by: Olblak <me@olblak.com>
Signed-off-by: Olblak <me@olblak.com>
Signed-off-by: Olblak <me@olblak.com>
Signed-off-by: Olblak <me@olblak.com>
… refactorUdashLogin
It appears that default logrus behavior is to log to stderr and not stdout -> https://github.com/sirupsen/logrus/blob/dd1b4c2e81afc5c255f216a722b012ed26be57df/logger.go#L89 I am reverting the stdout changes to stderr until a further discussion Signed-off-by: Olblak <me@olblak.com>
Signed-off-by: Olblak <me@olblak.com>
Now that I created the udash package, it's just makes more sense to move the publish method to the udash package. Signed-off-by: Olblak <me@olblak.com>
olblak
commented
Jul 29, 2023
olblak
commented
Jul 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
enhancement
New feature or request
experimental
Experimental feaure
udash
All things related to Udash
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up of #1344
This pullrequest introduces the following changes:
updatecli login
toupdatecli udash login --experimental https://app.updatecli.io
updatecli udash logout --experimental https://app.updatecli.io
updatecli udash config --experimental
None of the changes introduced in this PR or #1344 should affect the core behavior of Updatecli.
If Updatecli is executed in experimental mode and detected a config file in $DEFAULT_USER_CONFIG_DIR/updatecli/udash.json with a valid configuration such as `
Then Updatecli automatically publish reports to
http://localhost
An updatecli pipeline run looks like
Note the report url at the end of the pipeline execution
Test
No testing at this time
Additional Information
Udash is a new experiment around Updatecli to have a long live service to collect Updatecli pipeline reports and to provide different kind of visualisation than what is possible from a terminal.
More information on https://github.com/updatecli/udash
Tradeoff
Potential improvement
Instead of
upatecli udash config
, I am considering adding a subcommand to retrieve the token only such asupdatecli udash show token https://app.updatecli.io
The motivation is to make it easier to retrieve the access token we configuring ci environment