Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(autodiscovery/helm) allow advanced ignore/only rule #1752

Merged
merged 2 commits into from
Nov 9, 2023

Conversation

olblak
Copy link
Member

@olblak olblak commented Nov 9, 2023

Fix #1743

This pullrequest allows more advance ignore/only rules.
It's now possible to use helm dependency and container in the matching rule

For example

Only Update dependency `s3gw` in chart `chart/epinio` using version constraint
autodiscovery:
  # scmid is applied to all crawlers
  scmid: epinio
  crawlers:
    helm:
      only:
        - path: chart/epinio
          dependencies:
            "s3gw": ">1.0.0"
Only Update dependency `s3gw` in chart `chart/epinio` without version constraint
autodiscovery:
  # scmid is applied to all crawlers
  scmid: epinio
  crawlers:
    helm:
      only:
        - path: chart/epinio
          dependencies:
            "s3gw": ""
Only Update both dependency `s3gw` in chart `chart/epinio` using version constraint and container "longhorn/upgrade-responder"
autodiscovery:
  # scmid is applied to all crawlers
  scmid: epinio
  crawlers:
    helm:
      only:
        - path: chart/epinio
          dependencies:
            "s3gw": ">1.0.0"
        - path: chart/epinio
          containers:
            "longhorn/upgrade-responder": ""

Test

To test this pull request, you can run the following commands:

cd <to_package_directory>
go test

Additional Information

Tradeoff

Potential improvement

I didn't tested all possible scenarios...

Signed-off-by: Olblak <me@olblak.com>
@olblak olblak added enhancement New feature or request autodiscovery All things related to the autodiscovery feature labels Nov 9, 2023
Signed-off-by: Olblak <me@olblak.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
autodiscovery All things related to the autodiscovery feature enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature Request: ignore specific dependencies with helm autodiscovery
1 participant