Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(autodiscovery/npm): allow advanced ignore/only rule #1753

Merged
merged 2 commits into from
Nov 9, 2023
Merged

feat(autodiscovery/npm): allow advanced ignore/only rule #1753

merged 2 commits into from
Nov 9, 2023

Conversation

olblak
Copy link
Member

@olblak olblak commented Nov 9, 2023

Fix #1663

Similar to #1752

Test

To test this pull request, you can run the following commands:

cd pkg/plugins/autodiscovery/helm/ 
go test ./...
go build -o bin/updatecli
/bin/updatecli diff --config e2e/updatecli.d/warning.d/autodiscovery/npm/npm.yaml  --experimental --debug

Additional Information

Tradeoff

Potential improvement

@olblak
feat(autodiscovery/npm): allow advanced ignore/only rule
cc10f00 
Signed-off-by: Olblak <me@olblak.com>
@olblak olblak mentioned this pull request Nov 9, 2023
Closed
11 tasks
@olblak olblak merged commit 6878cf6 into updatecli:main Nov 9, 2023
6 checks passed
@olblak olblak mentioned this pull request Nov 9, 2023
Merged
@olblak olblak added autodiscovery All things related to the autodiscovery feature enhancement New feature or request labels Nov 9, 2023
This was referenced Nov 10, 2023
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
autodiscovery All things related to the autodiscovery feature enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Feature Request: NPM autodiscovery should allows to ignore specific npm package
1 participant
@olblak