-
-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat: support partial content for the resource "file" #313
Conversation
79ecb77
to
a796151
Compare
20142e5
to
4444dae
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, @dduportal for the effort in this pull request, excepted minor suggestion, it seems ready to me. I let you rebase and then merge the PR once you considered my comments.
|
||
// New returns a reference to a newly initialized File object from a Filespec | ||
// or an error if the provided Filespec triggers a validation error. | ||
func New(spec FileSpec) (*File, error) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it would be better to run all validation, collect every error in a list of errors and then exit an error if there is at least one error. The purpose is to detect every potential configuration issue.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It had been applied as we discussed: The method has a list of error strings, and they are returned one time for all.
Signed-off-by: Damien Duportal <damien.duportal@gmail.com>
…a line. Signed-off-by: Damien Duportal <damien.duportal@gmail.com>
…sage Signed-off-by: Damien Duportal <damien.duportal@gmail.com>
Doc PR (wip): updatecli/website#161 |
Fix #231 , depends on #321
This PR allows manipulating partial content of files.
Source of kind
file
can now:Conditions of kind
file
can now check that a file (or an URL) :Targets of kind
file
can now update a file:How to Test
examples/updateCli.generic/file.yaml
had been updated to be a "reference" of different casesfile
to ensure that a lot of cases can be run in less than 1 seconds (not mentioning the ability to debug easily)Click to show the code snippet
Additional Details
shell
,scm
andtext
are now providing a reusable Mock for some of their internals. This code is always stored within a file namedmocks.go