Feat(condition) allow to not specify a sourceID for conditions (resulting in no source used by the condition) #321
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dduportal
force-pushed
the
feat/suppress-source-on-condition
branch
from
892d41b
to
ac621bc
Compare
dduportal
force-pushed
the
feat/suppress-source-on-condition
branch
from
ac621bc
to
c22afa8
Compare
dduportal
added
condition
Signed-off-by: Damien Duportal <damien.duportal@gmail.com>
dduportal
force-pushed
the
feat/suppress-source-on-condition
branch
from
c22afa8
to
ab3909b
Compare
dduportal
changed the title
olblak
reviewed
Oct 21, 2021
| Spec interface{} | ||
| Scm map[string]interface{} | ||
| SourceID string `yaml:"sourceID"` | ||
| DependsOn []string `yaml:"depends_on"` |
There was a problem hiding this comment.
This makes me realize that we should define a rule and stay consistent between camelCase and snake_case
"depends_on" vs "disableSourceInput"
But this PR is not the place for this
olblak
approved these changes
Oct 21, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #305
This PR introduces a new attribute
disableSourceInputfor conditions. It allows to disable the source's value input, letting condition to be "standalone".The behavior depends on each resource: for instance in the case of a "shell", it won't append the value at the end of the command.
Todo: