Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat [conditions] use lower case for new attribute disablesourceinput #330

Merged
merged 2 commits into from
Oct 21, 2021

Conversation

dduportal
Copy link
Contributor

@dduportal dduportal commented Oct 21, 2021

As per #321 (comment), this PR does damage control on the naming convention by setting the attribute to lower case.

The doc. PR at updatecli/website#154 had been updated

@lemeurherve
Copy link
Member

Maybe I'm missing something but no camelCase, no snake_case, no PascalCase, only lower case for all variables names from now on?
What about the existing variables names? Should they keep their (mixed) cases or should they all be converted to lower case?

@dduportal
Copy link
Contributor Author

@lemeurherve sorry, i wrote the PR message too quickly: it's only about the freshly added attribute, and keeping it in lowercase to map to "most" of the other attributes.

The goal is NOT to define/apply a convention on the rest: it's just that I felt it was not necessary to introduce a new attrribute that would be different than the others (that are already not homogeneous 😅)

Signed-off-by: Damien Duportal <damien.duportal@gmail.com>
@lemeurherve
Copy link
Member

lemeurherve commented Oct 21, 2021

@dduportal make sense :)

Let's add a 1337c453 to the mix for the next one then!

image

@dduportal
Copy link
Contributor Author

@dduportal make sense :)

Let's add a 1337case to the mix for the next one then!

d154bl350urc31npu7: true

@olblak olblak enabled auto-merge (squash) October 21, 2021 18:25
@olblak olblak merged commit d4e82ed into updatecli:main Oct 21, 2021
@dduportal dduportal deleted the feat/naming-convention branch November 11, 2021 16:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
condition Modify condition resource enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants