Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Chore: bump golangcilint to 1.43 and apply updated code suggestions to resources file and yaml #415

Merged
merged 2 commits into from
Dec 15, 2021
Merged

Chore: bump golangcilint to 1.43 and apply updated code suggestions to resources file and yaml #415

merged 2 commits into from
Dec 15, 2021

Conversation

dduportal
Copy link
Contributor

@dduportal dduportal commented Dec 14, 2021 •
edited

This PR comes from the work in #412 .

It updates the golantci-lint configuration file to support the latest 1.43.x line.

It also applies some of its suggestions.

Test

To test this pull request, you can run the following commands:

go build -o dist/updatecli
./dist/updatecli diff --config ./examples/updatecli.generic/file.yaml
./dist/updatecli diff --config ./examples/updatecli.generic/yaml.yaml

Additional Information

Tradeoff

Potential improvement

olblak
olblak reviewed Dec 15, 2021
View reviewed changes
.golangci.yml Outdated Show resolved Hide resolved
olblak
olblak previously approved these changes Dec 15, 2021
View reviewed changes
Copy link
Member

@olblak olblak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for looking into that, I have been pushing back this for too long.
I made a minor suggestion that could help us to keep track of new golangci new versions.
The current PR is good as is

@olblak olblak added this to the 0.18.0 milestone Dec 15, 2021
@dduportal
chore(lint) bump golangcilint to 1.43.0
ccd95f1 
Signed-off-by: Damien Duportal <damien.duportal@gmail.com>
@dduportal
chore(file,yaml) apply golangci-lint suggestion (S1017)
0b12b62 
Signed-off-by: Damien Duportal <damien.duportal@gmail.com>
@olblak olblak merged commit 4249563 into updatecli:main Dec 15, 2021
@dduportal dduportal added resource-file Resource of kind File resource-yaml Resource of kind YAML and removed cleanup labels Dec 20, 2021
@dduportal dduportal changed the title Chore: bump golangcilint to 1.43 and apply updated code suggestions Chore: bump golangcilint to 1.43 and apply updated code suggestions to resources file and yaml Dec 20, 2021
@dduportal dduportal deleted the chore/golangcilint branch January 14, 2022 19:21
@dduportal dduportal mentioned this pull request Jan 30, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@olblak olblak olblak left review comments

Assignees
No one assigned
Labels
chore resource-file Resource of kind File resource-yaml Resource of kind YAML
Projects
None yet
Milestone
0.18.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@dduportal @olblak