-
-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(manifests) resource kind is case-insensitive (internal refactor) #412
Conversation
bae73e9
to
5ec8508
Compare
13a5730
to
245e679
Compare
39f0ca6
to
4ee417e
Compare
8b20daa
to
658a3c0
Compare
658a3c0
to
0b1b48c
Compare
ad80119
to
fdcb75e
Compare
37596cf
to
4f2c224
Compare
3f4c908
to
0b77c13
Compare
c706690
to
c96e98c
Compare
Signed-off-by: Damien Duportal <damien.duportal@gmail.com>
… plugin resources Signed-off-by: Damien Duportal <damien.duportal@gmail.com>
Signed-off-by: Damien Duportal <damien.duportal@gmail.com>
Signed-off-by: Damien Duportal <damien.duportal@gmail.com>
Introduces 3 sub directories: resources, scms and utils Signed-off-by: Damien Duportal <damien.duportal@gmail.com>
Co-authored-by: Hervé Le Meur <91831478+lemeurherve@users.noreply.github.com>
Signed-off-by: Damien Duportal <damien.duportal@gmail.com>
c96e98c
to
124e743
Compare
@dduportal Well done, it's a nice pull request. It's interesting to see that you implemented in ways hesitated to do. I hesitated a Like the same interface for source, condition, target, but in the end, your approach makes things clearer. |
I think before merging this PR we should also clean up the CONTRIBUTING |
So far I didn't identify any regression 🎉 |
Depends on #388 , #414, #415, #418, #453, #456, #457, #479, #480, #481, #482 (will be rebased once all merged).
This PR is a refactor around the plugins to factorize common behaviors of resources (e.g. sources, conditions and targets) when possible, by using struct composition (https://golangbot.com/inheritance/) to look-a-like OO Object-Oriented's inheritance.
The expected outcomes are:
kind
, is now case un-sensitiveI recommend you to review this PR commit by commit (without checking the 4 commits from #482 of course) since it is refactoring!
It introduces the following changes (1 per commit):
resource
with a ResourceConfig struct. This package defines the common behavior that any plugin resource should implement.kind
of each resource to be case insensitive 🥳Test
To test this pull request, you can run the following commands:
make test make test-short make test-e2e
Additional Information
Please note that this PR lays the foundation for #373, #413 and #497 (deprecating unused fileds)