fix(pullrequests) retrieve changelog from both 'successful' and 'attention' targets #425
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ntion' targets Signed-off-by: Damien Duportal <damien.duportal@gmail.com>
dduportal
force-pushed
the
fix/gh-423
branch
from
e6f96e2
to
c1b85d6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #423
Test
Tested on my fork, it opened the following PR: dduportal/docker-builder#3
which has the changelog content in the expandable block
Additional Information
Tradeoff
Potential improvement
In the future, wemight consider to separate the "execution" result of a target (failed, changed, not changed) from its status (run, skipped)