chore(shell) refactor to follow plugin conventions #456
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Damien Duportal <damien.duportal@gmail.com>
dduportal
force-pushed
the
chore/refactor-shell
branch
from
28f2ce9
to
ccf210d
Compare
lemeurherve
approved these changes
Jan 13, 2022
olblak
approved these changes
Jan 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is only a refactor of the shell provider to ensure that we keep the same naming conventions over plugins.
No functionnal changes (hence the
chore) label.It's part of the work in #412 .
Please note that the example had been update to be run from the repository's root (to be sure that #419 can work with it)
Test
To test this pull request, you can run the following commands:
go build -o ./dist/updatecli && ./dist/updatecli diff --config examples/updatecli.generic/shellAdditional Information
Tradeoff
Potential improvement