-
-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor the gittag plugin + fix sources of gittag #457
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dduportal
force-pushed
the
chore/refactor-git
branch
from
January 15, 2022 11:20
3ab93b1
to
951f41f
Compare
This was referenced Jan 15, 2022
dduportal
force-pushed
the
chore/refactor-git
branch
from
January 15, 2022 18:33
951f41f
to
60c3e26
Compare
dduportal
changed the title
Chore: refactor gittag plugin
Refactor + Fix the gittag plugin
Jan 15, 2022
dduportal
added
bug
Something isn't working
condition
Modify condition resource
resource-gittag
Resource of kind Git Tag
source
target
Related to updatecli target
labels
Jan 15, 2022
dduportal
changed the title
Refactor + Fix the gittag plugin
Refactor the gittag plugin + fix sources of gittag
Jan 15, 2022
dduportal
force-pushed
the
chore/refactor-git
branch
from
January 15, 2022 21:32
60c3e26
to
691f376
Compare
dduportal
force-pushed
the
chore/refactor-git
branch
2 times, most recently
from
January 16, 2022 11:08
18a47e5
to
56e073c
Compare
Signed-off-by: Damien Duportal <damien.duportal@gmail.com>
Signed-off-by: Damien Duportal <damien.duportal@gmail.com>
Signed-off-by: Damien Duportal <damien.duportal@gmail.com>
Signed-off-by: Damien Duportal <damien.duportal@gmail.com>
Fixes updatecli#467. The fix comes from stop holding state in version object to avoid reference/copy issues. Instead, the method "filer.Search()" returns the object Version by copy (struct of 2 strings, it's fine for memory). It also allows to returns early when needed. Signed-off-by: Damien Duportal <damien.duportal@gmail.com>
Fixes updatecli#469. This fix implies extracting the time of creation of each tag reference and sort by time before answering the list of tags. Signed-off-by: Damien Duportal <damien.duportal@gmail.com>
Signed-off-by: Damien Duportal <damien.duportal@gmail.com>
Signed-off-by: Damien Duportal <damien.duportal@gmail.com>
Signed-off-by: Damien Duportal <damien.duportal@gmail.com>
…t of disablesourceinput Signed-off-by: Damien Duportal <damien.duportal@gmail.com>
Signed-off-by: Damien Duportal <damien.duportal@gmail.com>
lemeurherve
reviewed
Jan 17, 2022
lemeurherve
reviewed
Jan 17, 2022
lemeurherve
reviewed
Jan 17, 2022
lemeurherve
reviewed
Jan 17, 2022
lemeurherve
reviewed
Jan 17, 2022
lemeurherve
reviewed
Jan 17, 2022
lemeurherve
reviewed
Jan 17, 2022
lemeurherve
reviewed
Jan 17, 2022
lemeurherve
reviewed
Jan 17, 2022
lemeurherve
reviewed
Jan 17, 2022
lemeurherve
reviewed
Jan 17, 2022
lemeurherve
reviewed
Jan 17, 2022
lemeurherve
reviewed
Jan 17, 2022
lemeurherve
reviewed
Jan 17, 2022
lemeurherve
reviewed
Jan 17, 2022
lemeurherve
reviewed
Jan 17, 2022
lemeurherve
previously approved these changes
Jan 17, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Small nipticks, LGTM otherwise!
Co-authored-by: Hervé Le Meur <91831478+lemeurherve@users.noreply.github.com>
Thanks for the review folks! I've enabled auto-merge (with squash). I've taken in account almost all feedbacks (except 2: I've added comments). As soon as you approve, this will be merged : subsequent comment will need ...a subsequent PR ;) |
lemeurherve
approved these changes
Jan 17, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
bug
Something isn't working
condition
Modify condition resource
resource-gittag
Resource of kind Git Tag
source
target
Related to updatecli target
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR comes from the work in progress in #412 and refactors the gittag plugin into its own package.
While working on this, 2 bugs where found on this plugin and reported (#467 #468). These 2 bugs are now corrected
Fix #467
Fix #469
Test
To test this pull request, you can run the following commands:
go build -o ./dist/updatecli && ./dist/updatecli diff --config examples/updatecli.generic/gitTag.yaml
should error only on the 2 targets (expected) with:
Additional Information
factorizing code on condition and target between "normal" and "SCM" methods