-
-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cleanup(sources): remove deprecated syntax 'source:' (singular source) #589
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dduportal
changed the title
Deprecate/single source
cleanup(sources): removes deprecated syntax 'source:' (singular source)
Mar 18, 2022
dduportal
force-pushed
the
deprecate/single-source
branch
2 times, most recently
from
March 18, 2022 18:18
151cb93
to
d4aeb41
Compare
dduportal
changed the title
cleanup(sources): removes deprecated syntax 'source:' (singular source)
cleanup(sources): remove deprecated syntax 'source:' (singular source)
Mar 20, 2022
dduportal
force-pushed
the
deprecate/single-source
branch
2 times, most recently
from
March 20, 2022 08:13
d2cefa1
to
3c11371
Compare
lemeurherve
previously approved these changes
Mar 20, 2022
dduportal
added a commit
to dduportal/website
that referenced
this pull request
Mar 20, 2022
- Deprecated field "version" - updatecli/updatecli#590 - Deprecated fields "postfix/prefix" - updatecli/updatecli#590 - Deprecated fields "replacers" - updatecli/updatecli#592 - SCM setup moved to the top level directive scms - updatecli/updatecli#388 - Deprecated top-level field source (singular source) - updatecli/updatecli#589 Signed-off-by: Damien Duportal <damien.duportal@gmail.com>
dduportal
force-pushed
the
deprecate/single-source
branch
from
March 20, 2022 13:52
3c11371
to
8d140ff
Compare
lemeurherve
previously approved these changes
Mar 20, 2022
|
dduportal
force-pushed
the
deprecate/single-source
branch
from
March 21, 2022 10:31
68c7e4e
to
bc82fa9
Compare
lemeurherve
previously approved these changes
Mar 21, 2022
olblak
previously approved these changes
Mar 21, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This cleanup is really great as it help my ongoing work about json schema generator
Signed-off-by: Damien Duportal <damien.duportal@gmail.com>
dduportal
force-pushed
the
deprecate/single-source
branch
from
March 21, 2022 19:56
4a93686
to
427b8d4
Compare
Sorry, had to rebase due to merge conflicts. I need at least another new approval (putting this PR in auto-merge) |
lemeurherve
approved these changes
Mar 21, 2022
dduportal
added a commit
to updatecli/website
that referenced
this pull request
Mar 22, 2022
- Deprecated field "version" - updatecli/updatecli#590 - Deprecated fields "postfix/prefix" - updatecli/updatecli#590 - Deprecated fields "replacers" - updatecli/updatecli#592 - SCM setup moved to the top level directive scms - updatecli/updatecli#388 - Deprecated top-level field source (singular source) - updatecli/updatecli#589 Signed-off-by: Damien Duportal <damien.duportal@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the deprecated syntax
source:
(singular source).Depends on #588
Associated documentation PR: updatecli/website#264
Test
To test this pull request, you can run the following commands:
make test
Additional Information
Tradeoff
Potential improvement