Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cleanup(sources): remove deprecated syntax 'source:' (singular source) #589

Merged
merged 1 commit into from
Mar 21, 2022

Conversation

dduportal
Copy link
Contributor

@dduportal dduportal commented Mar 18, 2022

This PR removes the deprecated syntax source: (singular source).

Depends on #588

Associated documentation PR: updatecli/website#264

Test

To test this pull request, you can run the following commands:

make test

Additional Information

Tradeoff

Potential improvement

@dduportal dduportal changed the title Deprecate/single source cleanup(sources): removes deprecated syntax 'source:' (singular source) Mar 18, 2022
@dduportal dduportal requested a review from olblak March 18, 2022 18:02
@dduportal dduportal force-pushed the deprecate/single-source branch 2 times, most recently from 151cb93 to d4aeb41 Compare March 18, 2022 18:18
@dduportal dduportal changed the title cleanup(sources): removes deprecated syntax 'source:' (singular source) cleanup(sources): remove deprecated syntax 'source:' (singular source) Mar 20, 2022
@dduportal dduportal force-pushed the deprecate/single-source branch 2 times, most recently from d2cefa1 to 3c11371 Compare March 20, 2022 08:13
lemeurherve
lemeurherve previously approved these changes Mar 20, 2022
pkg/core/config/main.go Outdated Show resolved Hide resolved
dduportal added a commit to dduportal/website that referenced this pull request Mar 20, 2022
- Deprecated field "version" - updatecli/updatecli#590
- Deprecated fields "postfix/prefix" - updatecli/updatecli#590
- Deprecated fields "replacers" - updatecli/updatecli#592
- SCM setup moved to the top level directive scms - updatecli/updatecli#388
- Deprecated top-level field source (singular source) - updatecli/updatecli#589

Signed-off-by: Damien Duportal <damien.duportal@gmail.com>
lemeurherve
lemeurherve previously approved these changes Mar 20, 2022
@dduportal dduportal added this to the 0.22.3 milestone Mar 20, 2022
@dduportal
Copy link
Contributor Author

  • I'm waiting for review from 2 maintainers on this one (to be really sure that I did not do something wrong).
  • Proposed milestone: 0.22.3

lemeurherve
lemeurherve previously approved these changes Mar 21, 2022
olblak
olblak previously approved these changes Mar 21, 2022
Copy link
Member

@olblak olblak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This cleanup is really great as it help my ongoing work about json schema generator

Signed-off-by: Damien Duportal <damien.duportal@gmail.com>
@dduportal
Copy link
Contributor Author

Sorry, had to rebase due to merge conflicts. I need at least another new approval (putting this PR in auto-merge)

@dduportal dduportal enabled auto-merge (squash) March 21, 2022 19:58
@dduportal dduportal merged commit 9d3a56d into updatecli:main Mar 21, 2022
@dduportal dduportal deleted the deprecate/single-source branch March 21, 2022 20:14
dduportal added a commit to updatecli/website that referenced this pull request Mar 22, 2022
- Deprecated field "version" - updatecli/updatecli#590
- Deprecated fields "postfix/prefix" - updatecli/updatecli#590
- Deprecated fields "replacers" - updatecli/updatecli#592
- SCM setup moved to the top level directive scms - updatecli/updatecli#388
- Deprecated top-level field source (singular source) - updatecli/updatecli#589

Signed-off-by: Damien Duportal <damien.duportal@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants