cleanup(gittag, githubrelease) remove deprecated code for field version
#590
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dduportal
changed the title
dduportal
changed the title
version
dduportal
force-pushed
the
deprecate/version
branch
from
6ee7d03
to
ec8a862
Compare
dduportal
added
resource-githubRelease
lemeurherve
previously approved these changes
Mar 20, 2022
dduportal
added a commit
to dduportal/website
that referenced
this pull request
Mar 20, 2022
- Deprecated field "version" - updatecli/updatecli#590 - Deprecated fields "postfix/prefix" - updatecli/updatecli#590 - Deprecated fields "replacers" - updatecli/updatecli#592 - SCM setup moved to the top level directive scms - updatecli/updatecli#388 - Deprecated top-level field source (singular source) - updatecli/updatecli#589 Signed-off-by: Damien Duportal <damien.duportal@gmail.com>
dduportal
force-pushed
the
deprecate/version
branch
from
ec8a862
to
f2c4ef5
Compare
…testing Signed-off-by: Damien Duportal <damien.duportal@gmail.com>
Signed-off-by: Damien Duportal <damien.duportal@gmail.com>
…rsion.Filter is used instead) Signed-off-by: Damien Duportal <damien.duportal@gmail.com>
dduportal
force-pushed
the
deprecate/version
branch
from
f2c4ef5
to
1deac50
Compare
lemeurherve
approved these changes
Mar 20, 2022
|
olblak
reviewed
Mar 21, 2022
olblak
approved these changes
Mar 21, 2022
Thanks, but don't be too harsh with yourself :) It's a looot of work, so let's improve this tool and its doc one step after the other |
dduportal
added a commit
to updatecli/website
that referenced
this pull request
Mar 22, 2022
- Deprecated field "version" - updatecli/updatecli#590 - Deprecated fields "postfix/prefix" - updatecli/updatecli#590 - Deprecated fields "replacers" - updatecli/updatecli#592 - SCM setup moved to the top level directive scms - updatecli/updatecli#388 - Deprecated top-level field source (singular source) - updatecli/updatecli#589 Signed-off-by: Damien Duportal <damien.duportal@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the deprecated code of the field
version.It also introduces the following changes:
Makefileto allow executing the end to end test with a custom binary directory (e.g. allowmake test-e2e VENOM_VAR_binpath=./custom-dist/to use the binaryupdateclilocated in./custom-dist/updatecli)Init()(interface ScmHandler) as it was only used to define versionfilters.Associated documentation PR: updatecli/website#264
Test
To test this pull request, you can run the following commands:
make testAdditional Information
Tradeoff
Potential improvement