cleanup(pipeline) remove deprecated code for prefix and postfix #591
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dduportal
force-pushed
the
deprecate/prefix-and-postfix
branch
from
cea8612
to
5c845a3
Compare
|
I need to double check but I think prefix and postfix are still "used" in manifest example and documentation |
|
I mean we should be sure to remove anu occurrence of this deprecated syntax |
Already done in updatecli/website#264 :) |
dduportal
force-pushed
the
deprecate/prefix-and-postfix
branch
from
5c845a3
to
a06bcce
Compare
|
lemeurherve
previously approved these changes
Mar 21, 2022
olblak
reviewed
Mar 21, 2022
Signed-off-by: Damien Duportal <damien.duportal@gmail.com>
dduportal
force-pushed
the
deprecate/prefix-and-postfix
branch
from
0f905b6
to
d442d4b
Compare
|
Last one \o/ |
lemeurherve
approved these changes
Mar 21, 2022
olblak
approved these changes
Mar 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the deprecated code for "prefix" and "postfix" (which have been replaced by transformers more than 1 year ago).
Depends on #590 (as there is a common change on the signature of a call to
ScmHandler.Init())Associated documentation PR: updatecli/website#264
Test
To test this pull request, you can run the following commands:
make testAdditional Information
Tradeoff
Potential improvement