pullrequest correctly search linked targets based on pullrequestID

[olblak]

Signed-off-by: Olblak me@olblak.com

Fix #836
In release 0.30.0, Updatecli automatically detects which targets are related to a pullrequest spec, for generating the pullrequest body.

So

pullrequests:
  jenkins:
    title: Bump Jenkins Version to {{ source "jenkins" }}
    kind: github
    scmid: github2
    targets:
      - jenkins

becomes

pullrequests:
  jenkins:
    title: Bump Jenkins Version to {{ source "jenkins" }}
    kind: github
    scmid: github2

But in the code I passed the wrong id value the pullrequest scmID instead of the pullrequets ID
I didn't detect this issue because in my tests environment, it's usually the same value.

Test

To test this pull request, you can run the following commands:

cp <to_package_directory>
go test

Additional Information

Tradeoff

Potential improvement

[hervelemeur]

I didn't detect this issue because in my tests environment, it's usually the same value.

Can tests be added to check this case?

[olblak]

I didn't detect this issue because in my tests environment, it's usually the same value.

Can tests be added to check this case?

Honestly I was wondering the same, because we need to try to open a PR.
I don't see an easy way other than adding a new e2e test

[olblak]

Here is one

[olblak]

well e2e test allowed me to discover another bug :D