Fix: yaml source workdir relying on scm #839
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Olblak <me@olblak.com>
|
Oh! I'm wondering if it's not the same type of bug I've got in my pending PR... |
Which one? I am curious about this bug because I am pretty sure we use this workflow but can't remember where |
|
I'm struggling to debug e2e tests, but I think the errors I'm encountering could be related to this workdir. |
|
well try.gitea.io seems to be dead. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Olblak me@olblak.com
Spot while testing #838
This appears to be a regression where the source yaml didn't use the correct scmID
Test
To test this pull request, you can run the following commands:
go build -o bin/updatecli . ./bin/updatecli diff --config e2e/updatecli.d/success.d/githubPullrequest.yamlAdditional Information
Tradeoff
/
Potential improvement
This part should deserve better UT, but I don't really have the time atm