-
-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for Docker default config file #900
Conversation
Nice work, I didn't realize how far you went. Indeed I need some e2e tests for different registries like ghcr.io dockerhub and quay |
I did some initial testing and I didn't find any regression, I need to find some ways to test with other registries than dockerhub or ghcr.io |
I confirm that your code fallback to the docker configuration file to retrieve credentials. |
The only 'regression' might be the registry for how dockerhub is resolved. It will be resolved to index.docker.io |
Which I don't think is a problem at all. If I recall correctly that URL was needed for the previous code which is now replaced by GGCR |
I am renaming the pullrequest to "Add support for Docker default config file" to highlight that this pullrequest is not only a great refactoring by fixing various issues but it's great enhancement that will benefit to autodiscovery feature. |
Signed-off-by: Sambhav Kothari <sambhavs.email@gmail.com>
@olblak fixed the failing registry test and rebased. Should be all good to go now. |
Fix #871
Fix #872
Fix #606
This PR guts the custom docker image/digest logic and replaces it with GGCR. This allows us to have a robust docker validation logic.
Test
To test this pull request, you can run the following commands:
Additional Information
Tradeoff
Potential improvement