Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add docker digest support for Updatecli condition #924

Merged
merged 6 commits into from
Oct 12, 2022

Conversation

olblak
Copy link
Member

@olblak olblak commented Oct 12, 2022

Add docker digest condition support and fix several regression introduced by #900

  • Add support for dockerdigest condition
  • dockerimage condition should default to source input if a tag is not defined
  • docker image should display information
  • Add e2e tests for docker image
  • Add e2e tests for docker digest

Test

To test this pull request, you can run the following commands:

go build -o bin/updatecli .
./bin/updatecli diff --config e2e/updatecli.d/success.d/dockerdigest.yaml
./bin/updatecli diff --config e2e/updatecli.d/success.d/dockerimage.yaml 

Additional Information

Tradeoff

Potential improvement

Put back dockerimage condition message

Signed-off-by: Olblak <me@olblak.com>
Signed-off-by: Olblak <me@olblak.com>
Signed-off-by: Olblak <me@olblak.com>
@olblak olblak added enhancement New feature or request resource-dockerdigest Resource of kind dockerDigest labels Oct 12, 2022
@olblak olblak added this to the 0.36.0 milestone Oct 12, 2022
Signed-off-by: Olblak <me@olblak.com>
Signed-off-by: Olblak <me@olblak.com>
Signed-off-by: Olblak <me@olblak.com>
@olblak olblak merged commit c80a018 into updatecli:main Oct 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request resource-dockerdigest Resource of kind dockerDigest
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant