Skip to content
This repository has been archived by the owner on Jun 8, 2020. It is now read-only.

Information leaks in some requests #28

Closed
ulissesferreira opened this issue Oct 17, 2018 · 1 comment
Closed

Information leaks in some requests #28

ulissesferreira opened this issue Oct 17, 2018 · 1 comment
Assignees
Labels
must-fix Top priority fix

Comments

@ulissesferreira
Copy link
Member

Due to the fact that sometimes we are lazy 😎 we are using SELECT * FROM ... and not handling the information leak that this causes. We are basically dumping all the information from a user without handling what is useful or not. We shouldn't send hashed passwords back and forth for example xD even though we are using SSL... It's just not a good practice.

TODO: go through all our requests and either stop using SELECT * and specify what we need OR take care of the extra information before we send it 👍

Easy fix and not a priority but must be taken care of before we launch.

@fabiofcferreira
Copy link
Collaborator

fabiofcferreira commented Oct 17, 2018

Just started working on a fix. Also, I really think it's a top priority since it can lead into Table Row ID exposed.

@fabiofcferreira fabiofcferreira changed the title [Security] [Must fix] Information leaks in some requests Information leaks in some requests Oct 17, 2018
@fabiofcferreira fabiofcferreira self-assigned this Oct 17, 2018
@fabiofcferreira fabiofcferreira added the must-fix Top priority fix label Oct 17, 2018
fabiofcferreira added a commit that referenced this issue Oct 17, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
must-fix Top priority fix
Projects
None yet
Development

No branches or pull requests

2 participants