This repository has been archived by the owner on Jul 13, 2021. It is now read-only.
More robust & strict hook deployment #142
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
September 15, 2016 03:53
Quote variable references properly in case "funny" characters make it to those variables. Some cases may seem probable, some less, but it's definitely more robust and consistent to apply quoting everywhere.
Previous version of Bash function ignored all possible cp failures. Also it created a global variable TO_COPY for no apparent reason. In Python API, some of these problems are not present or relevant, but copying errors are still ignored (probably would end up as one of mild risk cases). This patch fixes all above problems. If there's *any* cp error, both functions will log an error and exit wirh 'error' result. Additionally, this handles correctly the case when a source file copied by Bash function starts with dash.
It's not possible to continue with incomplete or missing hook script.
phracek
approved these changes
Sep 15, 2016
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This solves multiple (not all) issues discussed in last commenrt in rhbz#1334903.
Bash part tested with current downstream build (replaced common.sh, ran test).
Please see individual commits for more details.