Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support http remotes when detecting repo and owner #107

Merged
merged 1 commit into from
Jun 12, 2022

Conversation

satazor
Copy link
Contributor

@satazor satazor commented Jun 11, 2022

This pull-request adds support for git remotes using https. Inside github actions remote urls are all https:// by default.

const [, repo, owner] = 'https://github.com/uphold/github-changelog-generator'.match(/github\.com[:/]([^/]+)\/(.+?)(?:\.git)?$/);

console.log(repo, '|', owner);
// uphold | github-changelog-generator
const [, repo, owner] = 'git@github.com:uphold/github-changelog-generator.git'.match(/github\.com[:/]([^/]+)\/(.+?)(?:\.git)?$/);

console.log(repo, '|', owner);
// uphold | github-changelog-generator

@satazor satazor force-pushed the bugfix/support-http-remote branch 2 times, most recently from 9c99394 to a2ba15f Compare June 11, 2022 14:51
src/index.js Outdated Show resolved Hide resolved
@satazor satazor force-pushed the bugfix/support-http-remote branch from a2ba15f to 3c0d0cd Compare June 12, 2022 10:24
@satazor satazor force-pushed the bugfix/support-http-remote branch from 3c0d0cd to 7ca0c7f Compare June 12, 2022 10:29
@diogotorres97 diogotorres97 merged commit 4c7ee5e into master Jun 12, 2022
@diogotorres97 diogotorres97 deleted the bugfix/support-http-remote branch June 12, 2022 20:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants