Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update cookie definition to use root path #15

Merged
merged 1 commit into from May 9, 2018

Conversation

pgom
Copy link
Contributor

@pgom pgom commented May 9, 2018

This PR updates the setCookie method to always use root path when creating a cookie.

Copy link
Contributor

@hitmanmcc hitmanmcc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If this is a requirement then maybe we should add a test for this.

@hitmanmcc hitmanmcc merged commit 3b44908 into master May 9, 2018
@hitmanmcc hitmanmcc deleted the enhancement/cookie-path branch May 9, 2018 11:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants