Add scope and otp header to storage #30
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asoraiamartins
force-pushed
the
feature/reset-2fa-email
branch
3 times, most recently
from
ffbb921
to
a9ba19a
Compare
pgom
requested changes
Jan 17, 2020
src/core/errors/otp-required.js
Outdated
| @@ -6,7 +6,7 @@ export class OTPRequiredError extends BaseError { | |||
| return false; | |||
| } | |||
|
|
|||
| return headers['otp-token'].toUpperCase() === 'REQUIRED'; | |||
| return headers['otp-token'].toUpperCase() === 'REQUIRED' || headers['otp-token'].toUpperCase() === 'OPTIONAL'; | |||
asoraiamartins
force-pushed
the
feature/reset-2fa-email
branch
from
a9ba19a
to
9a7bed3
Compare
|
@pgom updated |
asoraiamartins
force-pushed
the
feature/reset-2fa-email
branch
from
9a7bed3
to
fcd80d8
Compare
SandroMachado
requested changes
Feb 11, 2020
src/core/sdk.js
Outdated
| @@ -21,7 +22,9 @@ export default class SDK { | |||
| accessTokenKey: 'uphold.access_token', | |||
| baseUrl: 'https://api.uphold.com', | |||
| itemsPerPage: 10, | |||
| otpToken: 'uphold.otp_token', | |||
asoraiamartins
force-pushed
the
feature/reset-2fa-email
branch
from
fcd80d8
to
51d11bc
Compare
|
@SandroMachado updated |
SandroMachado
approved these changes
Feb 14, 2020
NelsonBrandao
approved these changes
Feb 14, 2020
pgom
approved these changes
Feb 21, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds scope and otp-token header to storage to allow the user to recover 2fa by email when he's not logged in on the mobile app.