Resolving issue with secure delivery and image transformations. #187
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
#186
This fix is intended for the Secure Delivery feature.
When generating a secure url with transformations, per the documentation, the slash at the beginning and end of the uuid/transformation string must be stripped out before passing it off to the AkamaiToken generator.
When the slashes remain, it yields a valid signed URL with double slashes, which is a invalid path to the Uploadcare asset, presenting a 404 error to the user. The
$generator->getUrlTemplate()already appends these slashes when constructing and signing the url.Checklist