Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix an issue with the file list pagination #190

Merged
merged 4 commits into from
Mar 28, 2022
Merged

Fix an issue with the file list pagination #190

merged 4 commits into from
Mar 28, 2022

Conversation

andrew72ru
Copy link
Collaborator

Description

Fix pagination

  • add 'from' parameter to request;
  • add 'getPageRequestParameters' method to generate a previous/next links

Checklist

andrew72ru and others added 4 commits March 27, 2022 08:34
- add 'from' parameter to request;
- add 'getPageRequestParameters' method to generate a previous/next links
@codecov-commenter
Copy link

codecov-commenter commented Mar 28, 2022

Codecov Report

Merging #190 (7dfae95) into master (b92f466) will decrease coverage by 0.44%.
The diff coverage is 10.00%.

@@             Coverage Diff              @@
##             master     #190      +/-   ##
============================================
- Coverage     92.67%   92.23%   -0.45%     
- Complexity      853      859       +6     
============================================
  Files            54       54              
  Lines          1844     1854      +10     
============================================
+ Hits           1709     1710       +1     
- Misses          135      144       +9     
Impacted Files Coverage Δ
src/Apis/FileApi.php 82.06% <10.00%> (-5.34%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b92f466...7dfae95. Read the comment docs.

@rsedykh rsedykh changed the title Fix pagination Fix an issue with the file list pagination Mar 28, 2022
@rsedykh rsedykh merged commit 6563d2d into master Mar 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants