-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add conversion document info API #169
Conversation
WalkthroughThe recent changes bring enhancements to document handling with a new Changes
TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 4
Out of diff range and nitpick comments (2)
lib/uploadcare/client/conversion/document_conversion_client.rb (1)
25-27
: Consider adding documentation for thedocument_info
method to explain its purpose and usage.lib/uploadcare/entity/conversion/base_converter.rb (1)
26-28
: Consider adding documentation for theinfo
method to explain its purpose and usage.
@@ -556,7 +556,7 @@ An `Add-On` is an application implemented by Uploadcare that accepts uploaded fi | |||
##### AWS Rekognition | |||
|
|||
```ruby | |||
# Execute AWS Rekognition Add-On for a given target to detect labels in an image. | |||
# Execute AWS Rekognition Add-On for a given target to detect labels in an image. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Correct the comment to clarify the purpose of the AWS Rekognition Add-On.
- # Execute AWS Rekognition Add-On for a given target to detect labels in an image.
+ # Execute AWS Rekognition Add-On to detect labels in an image for a given file UUID.
Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation.
# Execute AWS Rekognition Add-On for a given target to detect labels in an image. | |
# Execute AWS Rekognition Add-On to detect labels in an image for a given file UUID. |
Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Review Details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (1)
- lib/uploadcare/entity/conversion/base_converter.rb (1 hunks)
Files skipped from review as they are similar to previous changes (1)
- lib/uploadcare/entity/conversion/base_converter.rb
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Review Details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (1)
- CHANGELOG.md (1 hunks)
Additional Context Used
LanguageTool (6)
CHANGELOG.md (6)
Near line 9: Possible typo: you repeated a word
Context: ...tConverter. ## 4.4.1 — 2024-04-27 ### Added * Added
AWS Rekognition Moderation` Add-On. * ...
Near line 120: In American English, abbreviations like “etc.” require a period.
Context: ...s mime-type, image (dimensions, format, etc), video information (duration, format, ...
Near line 120: In American English, abbreviations like “etc.” require a period.
Context: ...information (duration, format, bitrate, etc), audio information, etc - Field `met...
Near line 120: In American English, abbreviations like “etc.” require a period.
Context: ...rmat, bitrate, etc), audio information, etc - Fieldmetadata
that includes arbi...
Near line 126: This phrase is redundant (‘I’ stands for ‘interface’). Use simply “API”.
Context: ...plications ### Added - Add Uploadcare API interface: -Uploadcare::FileMetadata
-...
Near line 152: Possible typo: you repeated a word
Context: ...tureVerifier## 3.1.1 — 2021-10-13 - Fixed
Uploadcare::File#store- Fixed
Uploadcare::File#delete` ## 3.1.0 — 2...
Additional comments not posted (1)
CHANGELOG.md (1)
6-6
: Consider revising the changelog entry to avoid repetition of the word "Added".- * Added `Document Info` API in `DocumentConverter`. + * `Document Info` API added in `DocumentConverter`.
Description
Checklist
Summary by CodeRabbit
New Features
Document Info
API to retrieve detailed information about documents.Documentation
Uploadcare::SignedUrlGenerators::AkamaiGenerator
.