This repository has been archived by the owner on Feb 1, 2021. It is now read-only.
Add first draft of usage #9
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mirceanis
suggested changes
Apr 23, 2019
README.md
Outdated
| //Sign a JWT | ||
| const exampleJwtPayload = { iss: this.props.address, aud: this.props.address, name: 'test'} | ||
|
|
||
| RNUportSigner.signJwt(this.props.address, |
There was a problem hiding this comment.
this.props.address is highly specific and can induce confusion.
I think address is enough
README.md
Outdated
|
|
||
| // TODO: What to do with the module? | ||
| RNUportSigner; | ||
| ## Basic Signer Usage |
There was a problem hiding this comment.
The non-hd signer should be marked as deprecated.
The main reason is that there is no way to recover the keys and that may not be obvious.
README.md
Outdated
| rlpEncodedTx, //RLP Encoded eth transaction | ||
| 'simple' | ||
| ).then( txSig => { | ||
| console.log(sig.r) |
There was a problem hiding this comment.
the lambda has txSig param but the logs are using sig.r
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.