Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENOENT: no such file or directory when folder uses non-Roman characters #452

Closed
3 tasks done
ejektaflex opened this issue Sep 6, 2023 · 4 comments
Closed
3 tasks done
Labels
bug Something isn't working HIGH PRIORITY AAAAAAAAAAAAAAAAAAA!!

Comments

@ejektaflex
Copy link

ejektaflex commented Sep 6, 2023

Checklist

  • I have checked that this issue isn't addressed in the FAQ.
  • I have checked that this issue isn't addressed in any other issue or pull request.
  • I have tried setting my GPU ID.

Paste the logs

⚙️ Getting saveImageAs from localStorage png
⚙️ Getting model from localStorage {"label":"General Photo (Real-ESRGAN)","value":"realesrgan-x4plus"}
⚙️ Setting gpuId to empty string
🔀 Setting model to 
🔄 Resetting image paths
🔀 Setting model to realesrgan-x4plus
🔄 Resetting image paths
⤵️ Dropped file:  {"type":"image/png","filePath":"\\abc.png","extension":"png"}
🖼 Setting image path:  C:\あ\abc.png
🗂 Setting output path:  C:\あ
🖼 imagePath:  C:\あ\abc.png
🔤 Extension:  png
🔄 Resetting Upscaled Image Path
🏁 UPSCAYL
🐞 BACKEND REPORTED:  📢 Upscayl Command:  -i,C:\あ\abc.png,-o,C:\あ\abc_upscayl_4x_realesrgan-x4plus.png,-s,4,-m,C:\Program Files\Upscayl\resources\models,-n,realesrgan-x4plus,,,-f,png
🐞 BACKEND REPORTED:  image upscayl:  [0 NVIDIA GeForce RTX 4080]  queueC=2[8]  queueG=0[16]  queueT=1[2]
[0 NVIDIA GeForce RTX 4080]  bugsbn1=0  bugbilz=0  bugcopc=0  bugihfa=0
[0 NVIDIA GeForce RTX 4080]  fp16-p/s/a=1/1/1  int8-p/s/a=1/1/1
[0 NVIDIA GeForce RTX 4080]  subgroup=32  basic=1  vote=1  ballot=1  shuffle=1

🚧 UPSCAYL_PROGRESS:  [0 NVIDIA GeForce RTX 4080]  queueC=2[8]  queueG=0[16]  queueT=1[2]
[0 NVIDIA GeForce RTX 4080]  bugsbn1=0  bugbilz=0  bugcopc=0  bugihfa=0
[0 NVIDIA GeForce RTX 4080]  fp16-p/s/a=1/1/1  int8-p/s/a=1/1/1
[0 NVIDIA GeForce RTX 4080]  subgroup=32  basic=1  vote=1  ballot=1  shuffle=1

🐞 BACKEND REPORTED:  image upscayl:  [1 Intel(R) UHD Graphics 630]  queueC=0[1]  queueG=0[1]  queueT=0[1]
[1 Intel(R) UHD Graphics 630]  bugsbn1=0  bugbilz=0  bugcopc=0  bugihfa=0
[1 Intel(R) UHD Graphics 630]  fp16-p/s/a=1/1/1  int8-p/s/a=1/1/1
[1 Intel(R) UHD Graphics 630]  subgroup=32  basic=1  vote=1  ballot=1  shuffle=1

🚧 UPSCAYL_PROGRESS:  [1 Intel(R) UHD Graphics 630]  queueC=0[1]  queueG=0[1]  queueT=0[1]
[1 Intel(R) UHD Graphics 630]  bugsbn1=0  bugbilz=0  bugcopc=0  bugihfa=0
[1 Intel(R) UHD Graphics 630]  fp16-p/s/a=1/1/1  int8-p/s/a=1/1/1
[1 Intel(R) UHD Graphics 630]  subgroup=32  basic=1  vote=1  ballot=1  shuffle=1

🐞 BACKEND REPORTED:  image upscayl:  0.00%

🚧 UPSCAYL_PROGRESS:  0.00%

🐞 BACKEND REPORTED:  image upscayl:  8.33%

🚧 UPSCAYL_PROGRESS:  8.33%

🐞 BACKEND REPORTED:  image upscayl:  16.67%

🚧 UPSCAYL_PROGRESS:  16.67%

🐞 BACKEND REPORTED:  image upscayl:  25.00%

🚧 UPSCAYL_PROGRESS:  25.00%

🐞 BACKEND REPORTED:  image upscayl:  33.33%

🚧 UPSCAYL_PROGRESS:  33.33%

🐞 BACKEND REPORTED:  image upscayl:  41.67%

🚧 UPSCAYL_PROGRESS:  41.67%

🐞 BACKEND REPORTED:  image upscayl:  50.00%

🚧 UPSCAYL_PROGRESS:  50.00%

🐞 BACKEND REPORTED:  image upscayl:  58.33%

🚧 UPSCAYL_PROGRESS:  58.33%

🐞 BACKEND REPORTED:  image upscayl:  66.67%

🚧 UPSCAYL_PROGRESS:  66.67%

🐞 BACKEND REPORTED:  image upscayl:  75.00%

🚧 UPSCAYL_PROGRESS:  75.00%

🐞 BACKEND REPORTED:  image upscayl:  83.33%

🚧 UPSCAYL_PROGRESS:  83.33%

🐞 BACKEND REPORTED:  image upscayl:  91.67%

🚧 UPSCAYL_PROGRESS:  91.67%

🐞 BACKEND REPORTED:  💯 Done upscaling
🐞 BACKEND REPORTED:  ♻ Scaling and converting now...
🐞 BACKEND REPORTED:  ❌ Error reading original image metadata Error: ENOENT: no such file or directory, open 'C:\あ\abc_upscayl_4x_realesrgan-x4plus.png'
🚧 UPSCAYL_PROGRESS:  Error: ENOENT: no such file or directory, open 'C:\あ\abc_upscayl_4x_realesrgan-x4plus.png'
⚙️ Getting saveImageAs from localStorage png
⚙️ Getting model from localStorage {"label":"General Photo (Real-ESRGAN)","value":"realesrgan-x4plus"}
⚙️ Setting gpuId to empty string
⚙️ Getting rememberOutputFolder from localStorage false

Describe the Bug

When converting a file that is in a folder that uses Japanese characters, I get an error. I'm not sure if the folder's parent folder would still cause this error, but the base folder where the input/output reside being in Japanese will definitely cause an error.

Notably, it doesn't matter what the

To Reproduce

Create a folder called . Place your input image in there, and drag it into Upscayl. Convert (I used General Photo). It will (probably) fail.

Version/Commit Hash

2.7.5

OS Specifics

Windows 11, RTX 4080

Expected Behavior

No response

Screenshots

No response

@ejektaflex ejektaflex added the bug Something isn't working label Sep 6, 2023
@aaronliu0130 aaronliu0130 added the HIGH PRIORITY AAAAAAAAAAAAAAAAAAA!! label Sep 7, 2023
@aaronliu0130
Copy link
Member

I can reproduce with simplified Chinese chars.

⚙️ Getting saveImageAs from localStorage png
⚙️ Getting model from localStorage {"label":"General Photo (Ultramix Balanced)","value":"ultramix_balanced"}
⚙️ Setting gpuId to empty string
🔀 Setting model to 
🎯 GET_MODELS_LIST:  
🔄 Resetting image paths
🔀 Setting model to ultramix_balanced
⚙️ Getting saveImageAs from localStorage png
⚙️ Getting model from localStorage {"label":"General Photo (Ultramix Balanced)","value":"ultramix_balanced"}
⚙️ Setting gpuId to empty string
⚙️ Getting rememberOutputFolder from localStorage false
⚙️ Getting saveImageAs from localStorage png
⚙️ Getting model from localStorage {"label":"General Photo (Ultramix Balanced)","value":"ultramix_balanced"}
⚙️ Setting gpuId to empty string
🔀 Setting model to 
🔀 Setting model to ultramix_balanced
🔄 Resetting image paths
🐞 BACKEND REPORTED:  📄 Selected File Path:  C:\Users\aaron\测\78221_2.jpg
🖼 Selected Image Path:  C:\Users\aaron\测\78221_2.jpg
📁 Selected Image Directory:  C:\Users\aaron\测试
🖼 imagePath:  C:\Users\aaron\测\78221_2.jpg
🔤 Extension:  jpg
🔄 Resetting Upscaled Image Path
🏁 UPSCAYL
🐞 BACKEND REPORTED:  📢 Upscayl Command:  -i,C:\Users\aaron\测\78221_2.jpg,-o,C:\Users\aaron\测\78221_2_upscayl_2x_ultramix_balanced.png,-s,4,-m,C:\Program Files\Upscayl\resources\models,-n,ultramix_balanced,,,-f,png
🐞 BACKEND REPORTED:  image upscayl:  [0 Radeon RX 580 Series]  queueC=1[2]  queueG=0[1]  queueT=2[2]
[0 Radeon RX 580 Series]  bugsbn1=0  bugbilz=0  bugcopc=0  bugihfa=0
[0 Radeon RX 580 Series]  fp16-p/s/a=1/1/0  int8-p/s/a=1/1/1
[0 Radeon RX 580 Series]  subgroup=64  basic=1  vote=1  ballot=1  shuffle=1

🚧 UPSCAYL_PROGRESS:  [0 Radeon RX 580 Series]  queueC=1[2]  queueG=0[1]  queueT=2[2]
[0 Radeon RX 580 Series]  bugsbn1=0  bugbilz=0  bugcopc=0  bugihfa=0
[0 Radeon RX 580 Series]  fp16-p/s/a=1/1/0  int8-p/s/a=1/1/1
[0 Radeon RX 580 Series]  subgroup=64  basic=1  vote=1  ballot=1  shuffle=1

🐞 BACKEND REPORTED:  image upscayl:  0.00%

🚧 UPSCAYL_PROGRESS:  0.00%

🐞 BACKEND REPORTED:  💯 Done upscaling
🐞 BACKEND REPORTED:  ♻ Scaling and converting now...
🐞 BACKEND REPORTED:  ❌ Error reading original image metadata Error: ENOENT: no such file or directory, open 'C:\Users\aaron\测试\78221_2_upscayl_2x_ultramix_balanced.png'
🚧 UPSCAYL_PROGRESS:  Error: ENOENT: no such file or directory, open 'C:\Users\aaron\测试\78221_2_upscayl_2x_ultramix_balanced.png'
🛑 Stopping Upscayl
🔄 Resetting image paths
🔄 Resetting image paths
🐞 BACKEND REPORTED:  🛑 Stopping Upscaling Process 25036

@aaronliu0130
Copy link
Member

High priority since this is a kinda a regression (see #217), may be related to other failings of JIMP which we currently use for compression.

@NayamAmarshe
Copy link
Member

We're going to use sharp.js instead of jimp.

We really need to nail down this path issue as well. Sometimes the real-esrgan binary doesn't play nice with non-english letters.

@NayamAmarshe
Copy link
Member

I tested on macOS.

Image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working HIGH PRIORITY AAAAAAAAAAAAAAAAAAA!!
Projects
Status: Done
Development

No branches or pull requests

3 participants